Skip to content

Test support for multiple versions of ESLint Stylistic #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 1, 2025
Merged

Conversation

FloEdelmann
Copy link
Member

@FloEdelmann FloEdelmann commented Jul 31, 2025

Follow-up to #2830 (comment).

@ST-DDT It would be great if you could have a look at this 🙂

Copy link

changeset-bot bot commented Jul 31, 2025

🦋 Changeset detected

Latest commit: bdcd7f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

This comment was marked as resolved.

@FloEdelmann FloEdelmann marked this pull request as ready for review July 31, 2025 11:58
@FloEdelmann FloEdelmann requested review from ota-meshi and waynzh July 31, 2025 11:58
Copy link
Contributor

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I haven't tested this version in any projects though, to check whether this "breaks"/changes anything there.

eslint-plugin-vue supports quite a lot versions of stylistic. I probably would have dropped one or two of them...

Copy link
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks you!

@waynzh waynzh merged commit fd6fc41 into master Aug 1, 2025
15 checks passed
@waynzh waynzh deleted the stylistic branch August 1, 2025 07:29
@github-actions github-actions bot mentioned this pull request Aug 1, 2025
@FloEdelmann
Copy link
Member Author

check whether this "breaks"/changes anything there

Since this introduces only an optional dependency with nearly all versions allowed, I think it should be fine.

supports quite a lot versions of stylistic. I probably would have dropped one or two of them

Yeah, we should definitely do that in the future, but I didn't want to introduce a (potentially) breaking change in this small PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy