-
-
Notifications
You must be signed in to change notification settings - Fork 690
Test support for multiple versions of ESLint Stylistic #2884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b9021c9
Split ESLint v8 into separate test job
FloEdelmann 2324ad2
Add test job for old ESLint Stylistic versions
FloEdelmann f6a7888
Add ESLint Stylistic as optional peer dependency
FloEdelmann d45891b
Update dev version of ESLint Stylistic
FloEdelmann e26ce85
Fix `vue/comma-style` tests with newer ESLint Stylistic versions
FloEdelmann 32b030a
Fix `vue/func-call-spacing` tests with newer ESLint Stylistic versions
FloEdelmann af92175
Create changeset
FloEdelmann bdcd7f9
Reorganize test cases
FloEdelmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"eslint-plugin-vue": minor | ||
--- | ||
|
||
Added [`@stylistic/eslint-plugin`](https://eslint.style/) as optional peer dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
const { existsSync, readFileSync } = require('node:fs') | ||
const path = require('node:path') | ||
|
||
const eslintStylisticPackagePath = path.join( | ||
__dirname, | ||
'../..', | ||
'node_modules', | ||
'@stylistic', | ||
'eslint-plugin', | ||
'package.json' | ||
) | ||
const eslintStylisticVersion = existsSync(eslintStylisticPackagePath) | ||
? JSON.parse(readFileSync(eslintStylisticPackagePath, 'utf8')).version | ||
: undefined | ||
|
||
module.exports = { eslintStylisticVersion } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.