[QRG] Allow QRG unit selection per band #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hint: Place this at the end of <pre><?php print_r($this->session->userdata()); ?></pre> |
int2001
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step to improve the frequency input. Ref. #165
This adds another column to the bands table and allows choosing another frequency unit then the defaults.
To keep performance up this qrg units are written to the session data and the user_options. When logging in available qrgunits are written to the session data. This makes sure we don't call the database too much.
next step will be displaying the frequency's based on the qrgunit
Comment:
Why not starting with the minimum approach here and just improving the frequency input in the QSO logging? Well the frequency displays in Wavelog are either in Hz, which is really uncommon and not really handy or they are inconsistent.
Goal is to get a clean and intuitive WebUI, which is consistent, stable and fast at the same time. This includes imho a consistent way to display frequencies. Just one unit is not enough as in the hamradio world we have a lot of different bands and spectrum areas.
Hint: Ignore whitespace in this PR