Skip to content

[QRG] Improve Frequency Display #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 22, 2024
Merged

[QRG] Improve Frequency Display #784

merged 5 commits into from
Aug 22, 2024

Conversation

HB9HIL
Copy link
Contributor

@HB9HIL HB9HIL commented Aug 21, 2024

This PR improves the display format of frequencies in Wavelog.

Based in the used QRG unit in the Bands view (#544) the frequencies will be shown in the defined unit.
The function qrg_conversion() is built as generic as possible. There are various options to return different strings. If needed we could add json return aswell but maybe to a later point.

Frequency Input in QSO, Contest and SimpleFLE logging will be added to a later point.

@HB9HIL HB9HIL added enhancement New feature or request frontend things which are affecting Frontend/UI labels Aug 21, 2024
@HB9HIL HB9HIL added this to the 1.9 milestone Aug 21, 2024
@HB9HIL HB9HIL self-assigned this Aug 21, 2024
@HB9HIL HB9HIL linked an issue Aug 21, 2024 that may be closed by this pull request
@HB9HIL HB9HIL modified the milestones: 1.9, 1.8.3 Aug 21, 2024
@HB9HIL HB9HIL marked this pull request as ready for review August 21, 2024 12:05
Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. tested it as well - everything works as intended.

@HB9HIL HB9HIL merged commit 1357498 into wavelog:dev Aug 22, 2024
@HB9HIL HB9HIL deleted the qrg branch August 22, 2024 13:36
@lycanananas
Copy link

Could you improve it even more to be more like in QRZ which is de facto standard..

Frequency then user input then hard coded unit.

I often make mistakes when I input 28.470 not 28.470M..

image

@HB9HIL
Copy link
Contributor Author

HB9HIL commented Nov 10, 2024

@lukezaa this is the plan

@HB9HIL HB9HIL mentioned this pull request Nov 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend things which are affecting Frontend/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Frequency input
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy