Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Show YiR after creating account through Profile #5127

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T379794

Notes

Fixes an issue found in https://phabricator.wikimedia.org/T379794#10428455. After creating an account, there was no completion block assigned to navigate to Year in Review. This PR adds the completion handler (similar to how Login is working).

Test Steps

  1. Launch app while logged out.
  2. Tap YiR in Profile.
  3. Tap "Join Wikipedia / Log in"
  4. Tap "Join Wikipedia"
  5. Create a new account. Year in Review should present after successfully creating an account.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team January 6, 2025 22:56
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll leave testing to QA so we don't create too many test accounts

@mazevedofs mazevedofs merged commit 4c890c4 into main Jan 7, 2025
4 checks passed
@mazevedofs mazevedofs deleted the T379794-2 branch January 7, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy