Page MenuHomePhabricator
Create Task
Maniphest T247173

Hide "User:" prefix from the "Autopromote block" and "Autopromote restore" logs
Closed, ResolvedPublic
Actions

Description

Currently, group membership changes in Special:Log/rights do not show the "User:" prefix, but the "Autopromote block" and "Autopromote restore" logs still do. For consistency, we should also hide the "User:" prefix for those two subtypes.

Examples:
https://en.wikipedia.org/wiki/Special:Log?type=rights&user=&page=&wpdate=&tagfilter=&subtype=blockautopromote
https://en.wikipedia.org/wiki/Special:Log?type=rights&user=&page=&wpdate=&tagfilter=&subtype=restoreautopromote

See also T247174, a similar task for the global rights log.

Details

SubjectRepoBranchLines +/-
Hide "User:" prefix from autopromote log entriesmediawiki/extensions/AbuseFiltermaster+11 -0
Customize query in gerrit

Related Objects

Event Timeline

GTrang created this task.Mar 7 2020, 6:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2020, 6:59 PM
GTrang renamed this task from Hide "User:" prefix from "Autopromote block" and "Autopromote restore" logs to Hide "User:" prefix from the "Autopromote block" and "Autopromote restore" logs.Mar 7 2020, 7:10 PM
GTrang mentioned this in T247174: Hide "User:" prefix from the global rights log.Mar 7 2020, 7:14 PM
GTrang updated the task description. (Show Details)
Daimona subscribed.Mar 14 2020, 11:17 AM

I think this shouldn't be too hard. The DB rows is storing NS and text separately, so it's just a matter of choosing the right method to build the link. Since the AbuseFilterRightsLogFormatter doesn't handle links, it should probably reimplement some parent's method to do that (I haven't checked which one).

gerritbot added a comment.Sep 17 2020, 10:12 AM

Change 628060 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@master] Hide "User:" prefix from autopromote log entries

https://gerrit.wikimedia.org/r/628060

gerritbot added a project: Patch-For-Review.Sep 17 2020, 10:12 AM
matej_suchanek claimed this task.Sep 17 2020, 10:13 AM
Daimona closed this task as Resolved.Sep 17 2020, 11:07 AM
Daimona removed a project: Patch-For-Review.
gerritbot added a comment.Sep 17 2020, 11:26 AM

Change 628060 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Hide "User:" prefix from autopromote log entries

https://gerrit.wikimedia.org/r/628060

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 17 2020, 12:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy