| ifried | |
| Sep 3 2020, 8:54 PM |
| F32384657: Screen Shot 2020-10-14 at 10.49.33 AM.png | |
| Oct 14 2020, 2:50 PM |
| F32371065: minerva_alignment_before.png | |
| Oct 2 2020, 1:16 PM |
| F32371067: minerva_alignment_before_open.png | |
| Oct 2 2020, 1:16 PM |
| F32371071: minerva_alignment_after_open.png | |
| Oct 2 2020, 1:16 PM |
| F32371069: minerva_alignment_after.png | |
| Oct 2 2020, 1:16 PM |
| F32352571: Screenshot from 2020-09-16 11-14-22.png | |
| Sep 16 2020, 3:15 PM |
| F32248167: Screenshot 2020-09-07 at 8.48.12 AM.png | |
| Sep 7 2020, 3:23 AM |
| F32248166: Screenshot 2020-09-07 at 8.49.16 AM.png | |
| Sep 7 2020, 3:23 AM |
As a Watchlist Expiry user, I want the dropdown options to be left-aligned, so they do not have an unappealing or awkward appearance.
Acceptance Criteria:
Screenshot example:
This is what I see on mobile at the moment:
 |  |
I see two options here:
@ifried, do we also have control over the look of the dropdown? I noticed that it is looking different for both of us.
@Prtksxna My mistake! The issue shows up on desktop; not mobile. Let me know if you see the same behavior when you test desktop Minerva.
Okay, thanks, @MusikAnimal!
In that case, pinging @Prtksxna: Do you recommend that we have the dropdown be centered or full-width? I know we previously discussed that the dropdown should be left-aligned, but do you still feel it should be left-aligned if it is full-width? Thanks!
It looks like there's a difference in how Firefox and Chrome handle alignment within the dropdown. Should it be aligned left, or centred?
Change 628633 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/skins/MinervaNeue@master] Center align the expiry dropdown in watchstar widget
It looks like there's a difference in how Firefox and Chrome handle alignment within the dropdown. Should it be aligned left, or centred?
Sorry, ignore me, I can actually read now. :-)
Change 628633 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Center and align the expiry dropdown in watchstar widget
Change 628986 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/skins/MinervaNeue@REL1_35] Center and align the expiry dropdown in watchstar widget
Change 628986 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@REL1_35] Center and align the expiry dropdown in watchstar widget
Before this change:
| Dropdown closed | Dropdown open |
 |  |
After this change:
| Dropdown closed | Dropdown open |
 |  |
I tested it on a couple of mobile emulators (iPhone and Android). There isn't any noticeable difference when the viewport is narrow.
These changes have now been deployed. I have tested on frwiki (with Minerva skin) and the dropdown now has the options aligned (see screenshot example below). I'm marking this as Done.
