In T86979#9869340, @Ebrahim wrote:

Sure jQuery.ui has lost importance ever since but it's still not unused as I've made aware one of the issue of one of the tools on Wikimedia Commons for RTL languages interface so have applied on Commons "html[dir="rtl"] .ui-dialog { right: auto; }"

I agree with the two comments above me. This change makes it more difficult to distinguish between the main content of the page and the elements surrounding it.

Works like magic! Thanks a lot to anyone involved in fixing this.

In T345648#9147112, @matmarex wrote:

I'll backport the fix later today, which will let you access it again, and you'll be able to see which subscription was causing the problem. (It'd be interesting to know for us too.)

I have lately been unable to access [[Special:TopicSubscriptions]]. All I see on that special page is an error message (Fatal exception of type "Wikimedia\Assert\ParameterTypeException"). I reported it yesterday on https://w.wiki/7QY6. I do not recall ever using the API to do anything related to topic subscriptions. See screenshot below. Thanks!

Thank you for the patch! Seems to be fixed on 1.41.0-wmf.19.

By the way, it is indeed a new regression. As mentioned, it is almost certainly related to 5c683fbc1b0b. I have MediaWiki 1.39.3 installed locally on my PC, and in that version OOUI toggle switches are displayed correctly in RTL.

In T341116#8989848, @Amire80 wrote:

Removing "good first task" because I'm not sure that it's very easy. Other than that, I completely support this.

I actually started seeing it recently, and I suspect that it's a new regression, although I might be wrong.

Thank you for fixing it so quickly!

Just a little question, is there a plan to support this feature on RTL wikis when using the 2010 wikitext editor?

I understand the importance of limiting editing CSS/JS files; However, I do not think the proposed change should be implemented on all wikis. For instance, I have sysop privileges on some small wikis, where I also help maintaining the user interface every now and then (for example, I remove obsolete unnecessary JS code from common.js, as well as local CSS fixes for bugs that have already been fixed, etc.) There are not many active administrators on these small wikis, and thus the potential risk of unconstructive edits to CSS/JS files is very minor.

Never mind, I see that it is now translated on Beta-Cluster, so it probably just took more time than usual. Thanks anyway :)

In T196148#4248426, @Aklapper wrote:

Hi, what is "weird"/"quirky" exactly here? That the text does not fit and is cut at the end? Something else?
Please describe actual outcome and expected outcome in bug reports - thanks!

It will be great if this extension becomes translatable on translatewiki.net, but until it happens, I see no problem with translating it via the source code. Once this extension becomes translatable on translatewiki.net, these translations can be imported there by "FuzzyBot".

In T193260#4169175, @Niharika wrote:

Patch backported as part of the morning SWAT today. It works great. Thanks Ed.

@Guycn2 The problem should be fixed now. Feel free to reopen this task if not.

In T193288#4166224, @Esanders wrote:

Have you tried Ctrl+Shift+X?

Thanks a lot, it works!

Thanks for performing this change. So now it can be marked as "resolved", I guess?

For consistency, maybe we should also remove "probably you" from other messages as well:

• MediaWiki:Notificationemail body removed
• MediaWiki:Notificationemail body changed
• MediaWiki:Confirmemail body
• MediaWiki:Confirmemail body changed
• MediaWiki:Confirmemail body set
• MediaWiki:Passwordreset-emailtext-ip

In T190786#4094872, @Aklapper wrote:

1. After the patch gets a "+2" by a reviewer and gets merged, it will go live within a week.
2. master is always the Git branch to target as it will become the next deployed version. If it's an important change it could be backported to a different branch.

Thanks for your patch! :)

@Tgr
Done, thank you so much for your help! I have two questions:

1. When will this change take affect on Wikimedia wikis?
2. How can I determine which branch is the appropriate one for each patch? I ask so I can know for future patches that I'll write...

@Tgr I think I have succeeded! Could you please check it to make sure I haven't done anything worng?

@Aklapper: Thank you, but unfortunately I still get the same error message, even without the dollar sign. Anyway, I will ask on the talk page soon, but I think it's better if you or Tgr will write this specific patch... Thanks again.

In T190786#4087132, @Aklapper wrote:

@Guycn2: See https://www.mediawiki.org/wiki/Gerrit/Tutorial for some info. Happy hacking! :)

In T190882#4086552, @Zoranzoki21 wrote:

I will work on this.

In T190786#4084954, @Tgr wrote:

Thanks @Guycn2! Do you want to write a patch for it?

Thanks for fixing.

In T146393#2803485, @Aklapper wrote:

@Guycn2: Can you please clarify?

Thanks for fixing it