refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1)
#47760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Jul 16, 2025
| @@ -1856,8 +1856,8 @@ void Initialize(v8::Local<v8::Object> exports, | |||
| v8::Local<v8::Value> unused, | |||
| v8::Local<v8::Context> context, | |||
| void* priv) { | |||
| v8::Isolate* isolate = context->GetIsolate(); | |||
| gin_helper::Dictionary dict(isolate, exports); | |||
| v8::Isolate* const isolate = v8::Isolate::GetCurrent(); | |||
There was a problem hiding this comment.
For browser layer usages it would be better to replace with JavascriptEnvironment::GetIsolate
There was a problem hiding this comment.
Thanks! can you also adopt it for other shell/browser files that have been touched in this PR.
deepak1556
reviewed
Jul 16, 2025
deepak1556
reviewed
Jul 16, 2025
7c9ee3f to
ba655bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Part 1 of a very short series to remove calls to
v8::Context::GetIsolate()which is being deprecated.Even though the individual changes are pretty straightforward, the overall diff is pretty heavy due to the number of places where we are using that method. So I'm breaking into a couple of smaller PRs to make review easier.
This PR:
GetIsolate()inNodeBindings::CreateEnvironment()by adding av8::Isolate*arg to that method.GetIsolate()in the Node.js moduleInitialize()methods by usingv8::Isolate::GetCurrent()instead.Checklist
npm testpassesRelease Notes
Notes: none.