Skip to content

refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) #47760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 21, 2025
Merged

refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) #47760

merged 7 commits into from
Jul 21, 2025

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Jul 15, 2025 •
edited
Loading

Description of Change

Part 1 of a very short series to remove calls to v8::Context::GetIsolate() which is being deprecated.

Even though the individual changes are pretty straightforward, the overall diff is pretty heavy due to the number of places where we are using that method. So I'm breaking into a couple of smaller PRs to make review easier.

This PR:

  1. Stops using GetIsolate() in NodeBindings::CreateEnvironment() by adding a v8::Isolate* arg to that method.
  2. Stops using GetIsolate() in the Node.js module Initialize() methods by using v8::Isolate::GetCurrent() instead.

Checklist

Release Notes

Notes: none.

@ckerr ckerr added semver/patch backwards-compatible bug fixes target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 15, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 15, 2025
deepak1556
deepak1556 reviewed Jul 16, 2025
View reviewed changes
deepak1556
deepak1556 reviewed Jul 16, 2025
View reviewed changes
deepak1556
deepak1556 reviewed Jul 16, 2025
View reviewed changes
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 16, 2025
@ckerr ckerr force-pushed the refactor/avoid-deprecated-v8-Context-GetIsolate-pt-1 branch from 7c9ee3f to ba655bc Compare July 18, 2025 16:59
@ckerr ckerr requested review from codebytere and deepak1556 July 21, 2025 02:27
@ckerr
fixup! fixup! refactor: use v8::Isolate::GetCurrent() in Initialize()…
0ace097 
… methods

refactor: prefer JavascriptEnvironment::GetIsolate() in the browser layer
@codebytere codebytere merged commit 39cca58 into main Jul 21, 2025
99 of 102 checks passed
@codebytere codebytere deleted the refactor/avoid-deprecated-v8-Context-GetIsolate-pt-1 branch July 21, 2025 14:34
@release-clerk
Copy link

release-clerk bot commented Jul 21, 2025

No Release Notes

@trop trop bot mentioned this pull request Jul 21, 2025
Merged
@trop
Copy link
Contributor

trop bot commented Jul 21, 2025

I have automatically backported this PR to "38-x-y", please check out #47843

@trop trop bot added in-flight/38-x-y merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/38-x-y labels Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckerr @deepak1556 @codebytere
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy