refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1)
#47760
Conversation
| @@ -1856,8 +1856,8 @@ void Initialize(v8::Local<v8::Object> exports, | |||
| v8::Local<v8::Value> unused, | |||
| v8::Local<v8::Context> context, | |||
| void* priv) { | |||
| v8::Isolate* isolate = context->GetIsolate(); | |||
| gin_helper::Dictionary dict(isolate, exports); | |||
| v8::Isolate* const isolate = v8::Isolate::GetCurrent(); | |||
There was a problem hiding this comment.
For browser layer usages it would be better to replace with JavascriptEnvironment::GetIsolate
| @@ -125,16 +125,16 @@ void ElectronRendererClient::DidCreateScriptContext( | |||
| render_frame->GetWebFrame()->GetDocumentLoader()->SetDefersLoading( | |||
| blink::LoaderFreezeMode::kStrict); | |||
|
|
|||
| v8::Isolate* const isolate = renderer_context->GetIsolate(); | |||
There was a problem hiding this comment.
Any reason to not call v8::Isolate::GetCurrent() here already ?
There was a problem hiding this comment.
@deepak1556 see #24179 - we shouldn't be trying to use v8::Isolate::GetCurrent() if we have other options imho
There was a problem hiding this comment.
Not sure I follow, isn't getting isolate from context is being deprecated ? Whats' the alternative here, this is the renderer layer fwiw
There was a problem hiding this comment.
https://chromium-review.googlesource.com/c/chromium/src/+/6718066 v8::Isolate::GetCurrent is what is being preferred for third_party/blink irrespective of the source context.
| @@ -49,7 +49,7 @@ WebWorkerObserver::~WebWorkerObserver() = default; | |||
| void WebWorkerObserver::WorkerScriptReadyForEvaluation( | |||
| v8::Local<v8::Context> worker_context) { | |||
| v8::Context::Scope context_scope(worker_context); | |||
| auto* isolate = worker_context->GetIsolate(); | |||
| v8::Isolate* const isolate = worker_context->GetIsolate(); | |||
Description of Change
Part 1 of a very short series to remove calls to
v8::Context::GetIsolate()which is being deprecated.Even though the individual changes are pretty straightforward, the overall diff is pretty heavy due to the number of places where we are using that method. So I'm breaking into a couple of smaller PRs to make review easier.
This PR:
GetIsolate()inNodeBindings::CreateEnvironment()by adding av8::Isolate*arg to that method.GetIsolate()in the Node.js moduleInitialize()methods by usingv8::Isolate::GetCurrent()instead.Checklist
npm testpassesRelease Notes
Notes: none.