refactor: improve Electron settings version table #1712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d535a3a to
e926641
Compare
e926641 to
3df6e1d
Compare
dsanders11
requested changes
Jul 4, 2025
7f6ba30 to
bff81a9
Compare
|
@dsanders11 fixed in bff81a9! |
|
@codebytere, looks like that change works well if the version is at the top of the list, but if you're scrolled down the list and click one of the buttons, I'm seeing it snap back to the top of the list, and am unable to scroll down at all until the operation (download or delete) has finished. |
bff81a9 to
15b5fa2
Compare
15b5fa2 to
58f454b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this the table loaded all possible electron versions with no real ability to filter or search.
This PR virtualizes the list and adds input filtering.