refactor: improve Electron settings version table #1712
Conversation
d535a3a to
e926641
Compare
e926641 to
3df6e1d
Compare
7f6ba30 to
bff81a9
Compare
|
@dsanders11 fixed in bff81a9! |
|
@codebytere, looks like that change works well if the version is at the top of the list, but if you're scrolled down the list and click one of the buttons, I'm seeing it snap back to the top of the list, and am unable to scroll down at all until the operation (download or delete) has finished. |
15b5fa2 to
58f454b
Compare
|
@dsanders11 i think i've finally gotten it when you get a chance to re-review :D |
There was a problem hiding this comment.
LGTM. After local testing, the issue raised by @dsanders11 has been fixed.
There was a problem hiding this comment.
Can also confirm that issue is cleared up. 👍
There's a couple more visual things I think could use polish before merging.
- The buttons are no longer rendering as equal width like they do in Fiddle currently, so the button changes sizes while downloading, and when it says "Delete".
- If you type in gibberish for your filter, in dark mode the "No versions match your filter" text is dark when it should be light so that it's legible.
|
@dsanders11 sorry for accidental review request! will comment when changes are addressed :) |
14c1ff7 to
2f92b51
Compare
2f92b51 to
8e30c37
Compare
Prior to this the table loaded all possible electron versions with no real ability to filter or search.
This PR virtualizes the list and adds input filtering.