Skip to content

WIP: Fix linting that is failing the CI #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mtscout6
Copy link
Member

@mtscout6 mtscout6 commented Nov 18, 2016

May I suggest that you migrate this repo to an organization and institute protected branch support on master so PRs cannot be merged when the CI is failing?

See: #263

This will allow you to run `mocha -w` without any other special arguments and still get babel compilation
@mtscout6 mtscout6 changed the title Fix linting that is failing the CI WIP: Fix linting that is failing the CI Nov 18, 2016
@mtscout6
Copy link
Member Author

Looks like the mikedeboertest/TestRepo has been deleted which is why a number of the tests are broken. Does anyone know why that repo was deleted?

@mtscout6
Copy link
Member Author

I recreated the repo for that test user account

@mtscout6
Copy link
Member Author

Ok, I got hit with a 403 rate limited for the mikedeboertest account. So, I'll need to wait for that rate limit to go down before I can try again.

@mathieudutour
Copy link
Contributor

mathieudutour commented Nov 18, 2016

@mtscout6
Copy link
Member Author

@mathieudutour Instead of pushing yet another fork and another module pushed up to npm I'd much rather see #263 happen and just get more people to work together. @michael What is holding this up from getting more people to help with it? I can so two active forks of this project and I'd really hate to side step the team that originally put this promised based wrapper together.

@clayreimann
Copy link
Member

@mtscout6 @michael does not actively monitor the notifications from this repo. If we want to move this to an org (probably a good idea) we'll need to reach out to him directly.

@mathieudutour
Copy link
Contributor

mathieudutour commented Nov 18, 2016

Indeed, I'd be happy to help.

(I published my fork because I needed some of the opened PRs for a project.)

@clayreimann
Copy link
Member

great, well I'll reach out and see if we can get the repo moved.

@mtscout6
Copy link
Member Author

The Issue tests should be fixed now. Still have 10 more failing tests

@mtscout6
Copy link
Member Author

Nevermind, something is still deleting that repo...

@mathieudutour
Copy link
Contributor

I removed the dependency to that repo in my fork. I'll create a PR soon but there will be lots of changes.

@mathieudutour
Copy link
Contributor

see #401

@mtscout6
Copy link
Member Author

Closing in favor of #401

@mtscout6 mtscout6 closed this Nov 29, 2016
@mtscout6 mtscout6 deleted the fix-ci branch November 29, 2016 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy