-
Notifications
You must be signed in to change notification settings - Fork 777
WIP: Fix linting that is failing the CI #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will allow you to run `mocha -w` without any other special arguments and still get babel compilation
Looks like the mikedeboertest/TestRepo has been deleted which is why a number of the tests are broken. Does anyone know why that repo was deleted? |
I recreated the repo for that test user account |
Ok, I got hit with a 403 rate limited for the mikedeboertest account. So, I'll need to wait for that rate limit to go down before I can try again. |
I got the tests passing here: |
@mathieudutour Instead of pushing yet another fork and another module pushed up to npm I'd much rather see #263 happen and just get more people to work together. @michael What is holding this up from getting more people to help with it? I can so two active forks of this project and I'd really hate to side step the team that originally put this promised based wrapper together. |
Indeed, I'd be happy to help. (I published my fork because I needed some of the opened PRs for a project.) |
great, well I'll reach out and see if we can get the repo moved. |
…tRepo to get deleted.
The Issue tests should be fixed now. Still have 10 more failing tests |
Nevermind, something is still deleting that repo... |
I removed the dependency to that repo in my fork. I'll create a PR soon but there will be lots of changes. |
see #401 |
Closing in favor of #401 |
May I suggest that you migrate this repo to an organization and institute protected branch support on master so PRs cannot be merged when the CI is failing?
See: #263