Skip to content

Handle Server 2.10.26 returns No Responders instead of timeouts. #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 19, 2025
Merged

Handle Server 2.10.26 returns No Responders instead of timeouts. #1292

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed4dd06
Handle Server 2.10.26 returns No Responders instead of timeouts.
scottf Mar 18, 2025
d8e3165
fix constant value
scottf Mar 18, 2025
5b89ca4
fix flapper test
scottf Mar 18, 2025
cd59eba
self-review
scottf Mar 19, 2025
8cc4e4e
self-review - missed json read
scottf Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix flapper test
  • Loading branch information
@scottf
scottf committed Mar 18, 2025
commit 5b89ca45a892aa7baf84fcebf4cc0c9dd8acf492
28 changes: 16 additions & 12 deletions src/test/java/io/nats/client/api/StreamConfigurationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@

public class StreamConfigurationTests extends JetStreamTestBase {

public static final String DEFAULT_STREAM_NAME = "sname";

private StreamConfiguration getTestConfiguration() {
String json = ResourceUtils.dataAsString("StreamConfiguration.json");
StreamConfiguration sc = StreamConfiguration.instance(JsonParser.parseUnchecked(json));
Expand All @@ -46,7 +48,9 @@ private StreamConfiguration getTestConfiguration() {
public void testRoundTrip() throws Exception {
runInJsServer(si -> si.isNewerVersionThan("2.8.4"), nc -> {
CompressionOption compressionOption = atLeast2_10(ensureRunServerInfo()) ? S2 : None;
String stream = stream();
StreamConfiguration sc = StreamConfiguration.builder(getTestConfiguration())
.name(stream)
.mirror(null)
.sources()
.replicas(1)
Expand All @@ -58,17 +62,17 @@ public void testRoundTrip() throws Exception {
.compressionOption(compressionOption)
.build();
JetStreamManagement jsm = nc.jetStreamManagement();
validate(jsm.addStream(sc).getConfiguration(), true);
validate(jsm.addStream(sc).getConfiguration(), true, stream);
});
}

@Test
public void testSerializationDeserialization() throws Exception {
String originalJson = ResourceUtils.dataAsString("StreamConfiguration.json");
StreamConfiguration sc = StreamConfiguration.instance(originalJson);
validate(sc, false);
validate(sc, false, DEFAULT_STREAM_NAME);
String serializedJson = sc.toJson();
validate(StreamConfiguration.instance(serializedJson), false);
validate(StreamConfiguration.instance(serializedJson), false, DEFAULT_STREAM_NAME);
}

@Test
Expand Down Expand Up @@ -142,13 +146,13 @@ public void testInvalidNameInJson() throws Exception{
public void testConstruction() {
StreamConfiguration testSc = getTestConfiguration();
// from json
validate(testSc, false);
validate(testSc, false, DEFAULT_STREAM_NAME);

// test toJson
validate(StreamConfiguration.instance(JsonParser.parseUnchecked(testSc.toJson())), false);
validate(StreamConfiguration.instance(JsonParser.parseUnchecked(testSc.toJson())), false, DEFAULT_STREAM_NAME);

// copy constructor
validate(StreamConfiguration.builder(testSc).build(), false);
validate(StreamConfiguration.builder(testSc).build(), false, DEFAULT_STREAM_NAME);

// builder
StreamConfiguration.Builder builder = StreamConfiguration.builder()
Expand Down Expand Up @@ -184,15 +188,15 @@ public void testConstruction() {
.metadata(testSc.getMetadata())
.firstSequence(testSc.getFirstSequence())
.consumerLimits(testSc.getConsumerLimits());
validate(builder.build(), false);
validate(builder.addSources((Source)null).build(), false);
validate(builder.build(), false, DEFAULT_STREAM_NAME);
validate(builder.addSources((Source)null).build(), false, DEFAULT_STREAM_NAME);

List<Source> sources = new ArrayList<>(testSc.getSources());
sources.add(null);
Source copy = new Source(JsonParser.parseUnchecked(sources.get(0).toJson()));
assertEquals(sources.get(0).toString(), copy.toString());
sources.add(copy);
validate(builder.addSources(sources).build(), false);
validate(builder.addSources(sources).build(), false, DEFAULT_STREAM_NAME);

// covering add a single source
sources = new ArrayList<>(testSc.getSources());
Expand All @@ -202,7 +206,7 @@ public void testConstruction() {
builder.addSource(source);
}
builder.addSource(sources.get(0));
validate(builder.build(), false);
validate(builder.build(), false, DEFAULT_STREAM_NAME);

// equals and hashcode coverage
External external = copy.getExternal();
Expand Down Expand Up @@ -485,8 +489,8 @@ public void testDiscardPolicy() {
assertEquals(DiscardPolicy.Old, builder.build().getDiscardPolicy());
}

private void validate(StreamConfiguration sc, boolean serverTest) {
assertEquals("sname", sc.getName());
private void validate(StreamConfiguration sc, boolean serverTest, String name) {
assertEquals(name, sc.getName());
assertEquals("blah blah", sc.getDescription());
assertEquals(4, sc.getSubjects().size());
assertEquals("foo", sc.getSubjects().get(0));
Expand Down
1 change: 1 addition & 0 deletions src/test/java/io/nats/service/ServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ public void testServiceWorkflow() throws Exception {
.build();

service1.addServiceEndpoints(seRev1);
sleep(100); // give the service some time to get running. remember it's got to subscribe on the server

for (int x = 0; x < requestCount; x++) {
verifyServiceExecution(clientNc, REVERSE_ENDPOINT_NAME, REVERSE_ENDPOINT_SUBJECT, null);
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy