Handle Server 2.10.26 returns No Responders instead of timeouts.

nats-io · scottf · Mar 19, 2025 · Mar 18, 2025 · Mar 18, 2025 · Mar 18, 2025
commit ed4dd065cda92b9dcb04e33ee7aeaa0d77754b96
diff --git a/src/examples/java/io/nats/examples/jetstream/NatsJsUtils.java b/src/examples/java/io/nats/examples/jetstream/NatsJsUtils.java
@@ -80,7 +80,7 @@ public static StreamInfo createOrReplaceStream(JetStreamManagement jsm, String s
 
     public static StreamInfo createOrReplaceStream(JetStreamManagement jsm, String stream, StorageType storageType, String... subjects) {
         // in case the stream was here before, we want a completely new one
-        try { jsm.deleteStream(stream); } catch (Exception ignore) {}
+        safeDeleteStream(jsm, stream);
 
         try {
             return jsm.addStream(StreamConfiguration.builder()
@@ -467,10 +467,7 @@ public static void createCleanMemStream(Connection nc, String stream, String...
     }
 
     public static void createCleanMemStream(JetStreamManagement jsm, String stream, String... subs) throws IOException, JetStreamApiException {
-        try {
-            jsm.deleteStream(stream);
-        }
-        catch (Exception ignore) {}
+        safeDeleteStream(jsm, stream);
 
         StreamConfiguration sc = StreamConfiguration.builder()
             .name(stream)
@@ -479,4 +476,11 @@ public static void createCleanMemStream(JetStreamManagement jsm, String stream,
             .build();
         jsm.addStream(sc);
     }
+
+    public static void safeDeleteStream(JetStreamManagement jsm, String stream) {
+        try {
+            jsm.deleteStream(stream);
+        }
+        catch (Exception ignore) {}
+    }
 }
diff --git a/src/main/java/io/nats/client/BaseConsumeOptions.java b/src/main/java/io/nats/client/BaseConsumeOptions.java
@@ -44,6 +44,7 @@ public class BaseConsumeOptions implements JsonSerializable {
     protected final long idleHeartbeat;
     protected final int thresholdPercent;
     protected final boolean noWait;
+    protected final boolean raiseStatusWarnings;
 
     @SuppressWarnings("rawtypes") // Don't need the type of the builder to get its vars
     protected BaseConsumeOptions(Builder b) {
@@ -55,6 +56,8 @@ protected BaseConsumeOptions(Builder b) {
             messages = b.messages < 0 ? DEFAULT_MESSAGE_COUNT : b.messages;
         }
 
+        this.raiseStatusWarnings = b.raiseStatusWarnings;
+
         // validation handled in builder
         thresholdPercent = b.thresholdPercent;
         noWait = b.noWait;
@@ -81,6 +84,7 @@ public String toJson() {
         addField(sb, EXPIRES_IN, expiresIn);
         addField(sb, IDLE_HEARTBEAT, idleHeartbeat);
         addField(sb, THRESHOLD_PERCENT, thresholdPercent);
+        addFldWhenTrue(sb, RAISE_STATUS_WARNINGS, raiseStatusWarnings);
         addFldWhenTrue(sb, NO_WAIT, noWait);
         return endJson(sb).toString();
     }
@@ -101,12 +105,17 @@ public boolean isNoWait() {
         return noWait;
     }
 
+    public boolean raiseStatusWarnings() {
+        return raiseStatusWarnings;
+    }
+
     protected static abstract class Builder<B, CO> {
         protected int messages = -1;
         protected long bytes = 0;
         protected int thresholdPercent = DEFAULT_THRESHOLD_PERCENT;
         protected long expiresIn = DEFAULT_EXPIRES_IN_MILLIS;
         protected boolean noWait = false;
+        protected boolean raiseStatusWarnings = false;
 
         protected abstract B getThis();
 
@@ -190,6 +199,26 @@ public B thresholdPercent(int thresholdPercent) {
             return getThis();
         }
 
+        /**
+         * Raise status warning turns on sending status messages to the error listener.
+         * The default of to not raise status warning
+         * @return the builder
+         */
+        public B raiseStatusWarnings() {
+            this.raiseStatusWarnings = true;
+            return getThis();
+        }
+
+        /**
+         * Turn on or off raise status warning turns. When on, status messages are sent to the error listener.
+         * The default of to not raise status warning
+         * @return the builder
+         */
+        public B raiseStatusWarnings(boolean raiseStatusWarnings) {
+            this.raiseStatusWarnings = raiseStatusWarnings;
+            return getThis();
+        }
+
         /**
          * Build the options.
          * @return the built options

diff --git a/src/main/java/io/nats/client/impl/NatsFetchConsumer.java b/src/main/java/io/nats/client/impl/NatsFetchConsumer.java
@@ -22,7 +22,6 @@
 import static io.nats.client.BaseConsumeOptions.MIN_EXPIRES_MILLS;
 
 class NatsFetchConsumer extends NatsMessageConsumerBase implements FetchConsumer, PullManagerObserver {
-    private final boolean isNoWait;
     private final boolean isNoWaitNoExpires;
     private final long maxWaitNanos;
     private final String pullSubject;
@@ -34,7 +33,7 @@ class NatsFetchConsumer extends NatsMessageConsumerBase implements FetchConsumer
     {
         super(cachedConsumerInfo);
 
-        isNoWait = fetchConsumeOptions.isNoWait();
+        boolean isNoWait = fetchConsumeOptions.isNoWait();
         long expiresInMillis = fetchConsumeOptions.getExpiresInMillis();
         isNoWaitNoExpires = isNoWait && expiresInMillis == ConsumerConfiguration.LONG_UNSET;
 
@@ -55,7 +54,7 @@ class NatsFetchConsumer extends NatsMessageConsumerBase implements FetchConsumer
             .noWait(isNoWait)
             .build();
         initSub(subscriptionMaker.subscribe(null, null, null, inactiveThreshold));
-        pullSubject = sub._pull(pro, false, this);
+        pullSubject = sub._pull(pro, fetchConsumeOptions.raiseStatusWarnings(), this);
         startNanos = -1;
     }
 

diff --git a/src/main/java/io/nats/client/impl/NatsMessageConsumer.java b/src/main/java/io/nats/client/impl/NatsMessageConsumer.java
@@ -92,6 +92,6 @@ private void repull() {
             .expiresIn(opts.getExpiresInMillis())
             .idleHeartbeat(opts.getIdleHeartbeat())
             .build();
-        sub._pull(pro, false, this);
+        sub._pull(pro, opts.raiseStatusWarnings(), this);
     }
 }
diff --git a/src/main/java/io/nats/client/impl/PullMessageManager.java b/src/main/java/io/nats/client/impl/PullMessageManager.java
@@ -153,6 +153,7 @@ protected ManageResult manageStatus(Message msg) {
         switch (status.getCode()) {
             case NOT_FOUND_CODE:
             case REQUEST_TIMEOUT_CODE:
+            case NO_RESPONDERS_CODE:
                 if (raiseStatusWarnings) {
                     conn.executeCallback((c, el) -> el.pullStatusWarning(c, sub, status));
                 }

diff --git a/src/main/java/io/nats/client/support/ApiConstants.java b/src/main/java/io/nats/client/support/ApiConstants.java
@@ -163,6 +163,7 @@ public interface ApiConstants {
     String PURGED            = "purged";
     String PUSH_BOUND        = "push_bound";
     String QUEUE_GROUP       = "queue_group";
+    String RAISE_STATUS_WARNINGS = "raiseStatusWarnings";
     String RATE_LIMIT_BPS    = "rate_limit_bps";
     String REPLAY_POLICY     = "replay_policy";
     String REPLICA           = "replica";

diff --git a/src/test/java/io/nats/client/impl/JetStreamManagementTests.java b/src/test/java/io/nats/client/impl/JetStreamManagementTests.java
@@ -28,6 +28,7 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
 
 import static io.nats.client.support.DateTimeUtils.DEFAULT_TIME;
 import static io.nats.client.support.DateTimeUtils.ZONE_ID_GMT;
@@ -1545,4 +1546,93 @@ public void testCreateConsumerUpdateConsumer() throws Exception {
             assertEquals(fs1, ci.getConsumerConfiguration().getFilterSubject());
         });
     }
+
+    @Test
+    public void test1026() throws Exception {
+        ListenerForTesting listener = new ListenerForTesting();
+        jsServer.run(new Options.Builder().errorListener(listener), TestBase::atLeast2_10_26, nc -> {
+            JetStreamManagement jsm = nc.jetStreamManagement();
+            JetStream js = nc.jetStream();
+
+            String stream = stream();
+            String subject = stream();
+
+            assertThrows(JetStreamApiException.class, () -> jsm.getMessage(stream, 1));
+
+            createMemoryStream(jsm, stream, subject);
+
+            for (int x = 0; x < 5; x++) {
+                js.publish(subject, null);
+            }
+
+            String consumer = create1026Consumer(jsm, stream, subject);
+            PullSubscribeOptions so = PullSubscribeOptions.fastBind(stream, consumer);
+            JetStreamSubscription sub = js.subscribe(null, so);
+            jsm.deleteConsumer(stream, consumer);
+            sub.pull(5);
+            validate1026(sub.nextMessage(500), listener, false);
+
+            ConsumerContext context = setupFor1026Simplification(nc, jsm, listener, stream, subject);
+            validate1026(context.next(1000), listener, true); // simplification next never raises warnings, so empty = true
+
+            context = setupFor1026Simplification(nc, jsm, listener, stream, subject);
+            //noinspection resource
+            FetchConsumer fc = context.fetch(FetchConsumeOptions.builder().maxMessages(1).raiseStatusWarnings(false).build());
+            validate1026(fc.nextMessage(), listener, true); // we said not to raise status warnings in the FetchConsumeOptions
+
+            context = setupFor1026Simplification(nc, jsm, listener, stream, subject);
+            //noinspection resource
+            fc = context.fetch(FetchConsumeOptions.builder().maxMessages(1).raiseStatusWarnings().build());
+            validate1026(fc.nextMessage(), listener, false); // we said raise status warnings in the FetchConsumeOptions
+
+            context = setupFor1026Simplification(nc, jsm, listener, stream, subject);
+            IterableConsumer ic = context.iterate(ConsumeOptions.builder().raiseStatusWarnings(false).build());
+            validate1026(ic.nextMessage(1000), listener, true); // we said not to raise status warnings in the ConsumeOptions
+
+            context = setupFor1026Simplification(nc, jsm, listener, stream, subject);
+            ic = context.iterate(ConsumeOptions.builder().raiseStatusWarnings().build());
+            validate1026(ic.nextMessage(1000), listener, false); // we said raise status warnings in the ConsumeOptions
+
+            AtomicInteger count = new AtomicInteger();
+            MessageHandler handler = m -> count.incrementAndGet();
+
+            context = setupFor1026Simplification(nc, jsm, listener, stream, subject);
+            //noinspection resource
+            context.consume(ConsumeOptions.builder().raiseStatusWarnings(false).build(), handler);
+            Thread.sleep(100); // give time to get a message
+            assertEquals(0, count.get());
+            validate1026(null, listener, true);
+
+
+            context = setupFor1026Simplification(nc, jsm, listener, stream, subject);
+            //noinspection resource
+            context.consume(ConsumeOptions.builder().raiseStatusWarnings().build(), handler);
+            Thread.sleep(100); // give time to get a message
+            assertEquals(0, count.get());
+            validate1026(null, listener, false);
+        });
+    }
+
+    private static void validate1026(Message m, ListenerForTesting listener, boolean empty) throws InterruptedException {
+        assertNull(m);
+        Thread.sleep(100); // give time for the message to get there
+        assertEquals(empty, listener.getPullStatusWarnings().isEmpty());
+    }
+
+    private static ConsumerContext setupFor1026Simplification(Connection nc, JetStreamManagement jsm, ListenerForTesting listener, String stream, String subject) throws IOException, JetStreamApiException {
+        listener.reset();
+        String consumer = create1026Consumer(jsm, stream, subject);
+        ConsumerContext cCtx = nc.getConsumerContext(stream, consumer);
+        jsm.deleteConsumer(stream, consumer);
+        return cCtx;
+    }
+
+    private static String create1026Consumer(JetStreamManagement jsm, String stream, String subject) throws IOException, JetStreamApiException {
+        String consumer = name();
+        jsm.addOrUpdateConsumer(stream, ConsumerConfiguration.builder()
+            .durable(consumer)
+            .filterSubject(subject)
+            .build());
+        return consumer;
+    }
 }
diff --git a/src/test/java/io/nats/client/utils/TestBase.java b/src/test/java/io/nats/client/utils/TestBase.java
@@ -125,6 +125,10 @@ public static boolean atLeast2_9_0(ServerInfo si) {
         return si.isSameOrNewerThanVersion("2.9.0");
     }
 
+    public static boolean atLeast2_10_26(ServerInfo si) {
+        return si.isSameOrNewerThanVersion("2.10.26");
+    }
+
     public static boolean atLeast2_9_1(ServerInfo si) {
         return si.isSameOrNewerThanVersion("2.9.1");
     }