self-review

nats-io · scottf · Mar 19, 2025 · Mar 18, 2025 · Mar 18, 2025 · Mar 18, 2025
commit cd59eba7c5805404d3b04e6d5872e0c31cb1faaa
diff --git a/src/main/java/io/nats/client/BaseConsumeOptions.java b/src/main/java/io/nats/client/BaseConsumeOptions.java
@@ -56,11 +56,10 @@ protected BaseConsumeOptions(Builder b) {
             messages = b.messages < 0 ? DEFAULT_MESSAGE_COUNT : b.messages;
         }
 
-        this.raiseStatusWarnings = b.raiseStatusWarnings;
-
         // validation handled in builder
         thresholdPercent = b.thresholdPercent;
         noWait = b.noWait;
+        raiseStatusWarnings = b.raiseStatusWarnings;
 
         // if it's not noWait, it must have an expiresIn
         // we can't check this in the builder because we can't guarantee order

diff --git a/src/test/java/io/nats/client/impl/JetStreamManagementTests.java b/src/test/java/io/nats/client/impl/JetStreamManagementTests.java
@@ -1548,14 +1548,14 @@ public void testCreateConsumerUpdateConsumer() throws Exception {
     }
 
     @Test
-    public void test1026() throws Exception {
+    public void testNoRespondersWhenConsumerDeleted() throws Exception {
         ListenerForTesting listener = new ListenerForTesting();
         jsServer.run(new Options.Builder().errorListener(listener), TestBase::atLeast2_10_26, nc -> {
             JetStreamManagement jsm = nc.jetStreamManagement();
             JetStream js = nc.jetStream();
 
             String stream = stream();
-            String subject = stream();
+            String subject = subject();
 
             assertThrows(JetStreamApiException.class, () -> jsm.getMessage(stream, 1));
 
@@ -1603,7 +1603,6 @@ public void test1026() throws Exception {
             assertEquals(0, count.get());
             validate1026(null, listener, true);
 
-
             context = setupFor1026Simplification(nc, jsm, listener, stream, subject);
             //noinspection resource
             context.consume(ConsumeOptions.builder().raiseStatusWarnings().build(), handler);
@@ -1613,9 +1612,9 @@ public void test1026() throws Exception {
         });
     }
 
-    private static void validate1026(Message m, ListenerForTesting listener, boolean empty) throws InterruptedException {
+    private static void validate1026(Message m, ListenerForTesting listener, boolean empty) {
         assertNull(m);
-        Thread.sleep(100); // give time for the message to get there
+        sleep(100); // give time for the message to get there
         assertEquals(empty, listener.getPullStatusWarnings().isEmpty());
     }