Skip to content

BUG: Fix ExtensionArray binary op protocol #61990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tisjayy
Copy link
Contributor

@tisjayy tisjayy commented Jul 29, 2025

@tisjayy tisjayy closed this Jul 29, 2025
@tisjayy tisjayy reopened this Jul 29, 2025
@tisjayy tisjayy force-pushed the fix-ea-non-1d-ops branch from f9cb022 to 9496569 Compare July 29, 2025 05:21
@tisjayy

This comment was marked as resolved.

@tisjayy

This comment was marked as resolved.

@tisjayy tisjayy closed this Jul 29, 2025
@tisjayy tisjayy reopened this Jul 29, 2025
@tisjayy tisjayy closed this Jul 29, 2025
@tisjayy tisjayy reopened this Jul 29, 2025
@tisjayy

This comment was marked as resolved.

@tisjayy tisjayy changed the title BUG: NotImplemented for non-1D BooleanArray ops; add numeric EA shape error tests BUG: Fix ExtensionArray binary op protocol, return NotImplemented instead of raising NotImplementedError Jul 29, 2025
@tisjayy tisjayy changed the title BUG: Fix ExtensionArray binary op protocol, return NotImplemented instead of raising NotImplementedError BUG: Fix ExtensionArray binary op protocol Jul 29, 2025
@@ -856,6 +856,33 @@ def test_modulo_zero_int(self):
expected = Series([np.nan, 0.0])
tm.assert_series_equal(result, expected)

def test_np_array_mul_ea_array_returns_extensionarray(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a GH ref

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! i will probably do it by tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Operations not implemented for non-1D ExtensionArrays
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy