BUG: Fix ExtensionArray binary op protocol #61990
Open
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd tests for numeric EA shape errors
f9cb022 to
9496569
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
for more information, see https://pre-commit.ci
This comment was marked as resolved.
This comment was marked as resolved.
for more information, see https://pre-commit.ci
arthurlw
reviewed
Jul 30, 2025
| ea_array = array([1, 2, 3, 4, 5], dtype="Int64") | ||
| result = np_array * ea_array | ||
| assert isinstance(result, type(ea_array)) | ||
| tm.assert_equal(result, array([1, 4, 9, 16, 25], dtype="Int64")) |
There was a problem hiding this comment.
is this actually affected by this PR? if not i expect it is already tested?
There was a problem hiding this comment.
Test checks that multiplying a NumPy array by an ExtensionArray gives the correct type (an ExtensionArray), which means the fallback via NotImplemented is working as intended. I couldnt find anything similar in test_numeric.py or some other files i tried to look into.
There was a problem hiding this comment.
if you think its checked elsewhere, i will remove it
This comment was marked as resolved.
This comment was marked as resolved.
for more information, see https://pre-commit.ci
This comment was marked as resolved.
This comment was marked as resolved.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.