Fix implicit to and from bool type juggling #60890

Girgias · 2025-06-24T12:28:30Z

Q	A
Branch?	7.4 (but can rebase to lower)
Bug fix?	maybe
New feature?	no
Deprecations?	no
Issues	N/A
License	MIT

This is to see part of the impact of php/php-src#18879, and it seems to be finding some bugs in tests or SF itself, but I would need confirmation from other people.

This is very much W.I.P. and I might use CI to check that my changes are correct as I have some local test failures even just running with 8.4.8

I am well aware the commit messages are kinda useless at the moment, but they are somewhat self-contained, so they can be looked at individually.

carsonbot · 2025-06-24T12:28:33Z

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php

src/Symfony/Component/DependencyInjection/Definition.php

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php

src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php

src/Symfony/Component/ErrorHandler/ErrorHandler.php

stof · 2025-06-24T13:23:51Z

Some of those changes are definitely legitimate as they are clearly mistakes in the existing code that went unnoticed (static analysis could catch them, but our CI only reports new violations in each PR and we never worked on fixing issues reported in existing code):

the wrong parameter passed in the instantiation of Isbn
the wrong type passed to IntlTestHelper
the wrong type passed to stream_set_blocking
the wrong parameter type in the internal method of GraphvizDumper

Those could definitely be submitted directly (against the 6.4 branch).

We have other cases (when using preg_match or bitwise comparisons) where we indeed rely on the implicit type juggling of the return type, which are legitimate changes once PHP deprecates those type juggling rules (static analysis probably also prevents them for new code).
As we will want to support PHP 8.5 in the 6.4 branch, fixes for them should also be submitted against 6.4 (I would suggest separating them from the ones fixing clear mistakes).

As reported in my review comments, the changes done in the DI component look wrong to me (and are the cause of failures in the CI as well)

Girgias · 2025-06-24T13:28:22Z

Some of those changes are definitely legitimate as they are clearly mistakes in the existing code that went unnoticed (static analysis could catch them, but our CI only reports new violations in each PR and we never worked on fixing issues reported in existing code):
* the wrong parameter passed in the instantiation of `Isbn`

* the wrong type passed to `IntlTestHelper`

* the wrong type passed to `stream_set_blocking`

* the wrong parameter type in the internal method of GraphvizDumper
Those could definitely be submitted directly (against the 6.4 branch).

We have other cases (when using preg_match or bitwise comparisons) where we indeed rely on the implicit type juggling of the return type, which are legitimate changes once PHP deprecates those type juggling rules (static analysis probably also prevents them for new code). As we will want to support PHP 8.5 in the 6.4 branch, fixes for them should also be submitted against 6.4 (I would suggest separating them from the ones fixing clear mistakes).

As reported in my review comments, the changes done in the DI component look wrong to me (and are the cause of failures in the CI as well)

Yes I had figured out the cause, but I was having some other local failures before that made it difficult to waddle through stuff. There is also a bug in master on php-src which is not helping me to get a good overview of the situation.

Question about Isbn should I drop the null argument as it's the default or not?

stof · 2025-06-24T13:37:14Z

src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckTypeDeclarationsPassTest.php

@@ -336,7 +336,7 @@ public function testProcessFailsOnPassingClassToScalarTypedParameter()
        (new CheckTypeDeclarationsPass(true))->process($container);
    }

-    public function testProcessSuccessOnPassingBadScalarType()
+    public function xtestProcessSuccessOnPassingBadScalarType()


why skipping this test ?

I stole this from @nicolas-grekas WIP commit: nicolas-grekas@02e3881

src/Symfony/Bundle/TwigBundle/Tests/Functional/AttributeExtensionTest.php

src/Symfony/Component/String/LazyString.php

…alse

…first arg

src/Symfony/Component/DependencyInjection/Definition.php

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php

src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php

stof · 2025-06-27T15:40:20Z

...mponent/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php

@@ -65,7 +65,7 @@ public static function provideTransformations()
    public function testTransform($from, $to, $locale)
    {
        // Since we test against other locales, we need the full implementation
-        IntlTestHelper::requireFullIntl($this, false);
+        IntlTestHelper::requireFullIntl($this, null);


I suggest omitting null entirely as it is optional (as done in some of the impacted files btw).

I'll do that when I have time and have gone through the other issues.

Not sure what those asserts are doing however

There is no need to test false as this is a PHP engine behaviour to cast to empty string

Girgias · 2025-06-29T12:08:48Z

There are a few cases where I don't seem to be able to find the root cause. A big one is:

  1062x: Symfony\Component\Console\Tests\Descriptor\AbstractDescriptorTestCase::normalizeOutput(): Passing bool to parameter #1 ($output) of type string is deprecated
    942x in JsonDescriptorTest::testDescribeApplication from Symfony\Component\Console\Tests\Descriptor
    56x in JsonDescriptorTest::testDescribeInputOption from Symfony\Component\Console\Tests\Descriptor
    24x in JsonDescriptorTest::testDescribeInputArgument from Symfony\Component\Console\Tests\Descriptor
    24x in JsonDescriptorTest::testDescribeInputDefinition from Symfony\Component\Console\Tests\Descriptor
    16x in JsonDescriptorTest::testDescribeCommand from Symfony\Component\Console\Tests\Descriptor

This is possibly something that should be fixed on PHP's side

This PR was squashed before being merged into the 6.4 branch. Discussion ---------- Fix various bool-type coercions | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no  | Issues | | License | MIT This is cherry-picking some of the commits from #60890 which are basically bugs. Not sure what the commit naming policy is so do let me know if you want me to manually rebase and rename commits following some guidelines. Commits ------- b3d30e3 Fix various bool-type coercions

stof · 2025-07-15T15:29:49Z

@Girgias you can define the SYMFONY_DEPRECATIONS_HELPER env variable with a regex using / as delimiter (this is important as only strings starting with / are considered to be regex in the different syntaxes supported for that config). When this regex matches the message of a deprecation, the test execution will stop and the backtrace of the deprecation will be reported. This allows to identify the source of the deprecation.

nicolas-grekas · 2025-07-22T14:29:04Z

Continued in #61203, thanks for submitting!

stof reviewed Jun 24, 2025

View reviewed changes

src/Symfony/Component/ErrorHandler/ErrorHandler.php Show resolved Hide resolved

carsonbot closed this Jun 24, 2025

nicolas-grekas reopened this Jun 24, 2025

Girgias force-pushed the bool-type-juggling branch from d89795e to b812e26 Compare June 24, 2025 13:33

Girgias marked this pull request as ready for review June 24, 2025 13:35

Girgias requested review from lyrixx, yceruto, kbond, dunglas and xabbuh as code owners June 24, 2025 13:35

carsonbot added the Status: Needs Review label Jun 24, 2025

carsonbot added this to the 7.4 milestone Jun 24, 2025

symfony deleted a comment from carsonbot Jun 24, 2025

stof reviewed Jun 24, 2025

View reviewed changes

src/Symfony/Component/String/LazyString.php Outdated Show resolved Hide resolved

Girgias force-pushed the bool-type-juggling branch 2 times, most recently from a249be4 to e2cdfd7 Compare June 25, 2025 21:15

Girgias added 7 commits June 27, 2025 12:09

Pull fixes from Nicolas

d7109ac

Pull ignores/suppressed tests from Nicolas

4212ed9

Use false instead of 0

90c0a98

IntlTestHelper::requireFullIntl() use null as second arg instead of f…

d0834ee

…alse

Check return value of getenv()

d387c49

Symfony\Component\Validator\Constraints\Isbn does not take a bool as …

ad4fd82

…first arg

intl false instead of null

2ee80c5

stof reviewed Jun 27, 2025

View reviewed changes

Girgias added 13 commits June 29, 2025 13:04

Yield empty string when no doc comment exists

17ab127

Set value to null if parse_url() fails badly and returns false

f677c74

Fix deprecation with PHPUnit's assertTrue

90401c0

Not sure what those asserts are doing however

Remove ZPP test

85de1ec

There is no need to test false as this is a PHP engine behaviour to cast to empty string

file_get_contents() does not take a fopen mode parameter

72b9650

Symfony\Component\String\LazyString::resolve() add explicit string cast

aa67b63

Fix string to true type juggling in test

2317f30

Remove ZPP test

4edbb43

There is no need to test false as this is a PHP engine behaviour to cast to empty string

Use empty string instead of false

2017a7b

Explicit cast to bool from string

e816540

Definition::addMethodCall() arg 3 must be a bool v2

8afc277

Fix test passing false to ?string type

4d883cc

Remove ZPP tests testing false to string coercion

218a4f8

Girgias added 6 commits June 29, 2025 13:42

NumberFormatter::setAttribute() takes values of type int|float

5397577

This is possibly something that should be fixed on PHP's side

Default non-existing environment variable to empty string

dfcef56

Split grapheme extraction and check if one is found

a828919

Fix substr with bool?

52dec0e

Use '1' instead of true

f3286e3

cookie_httponly key does not support values of auto

fa063a6

Girgias force-pushed the bool-type-juggling branch from e2cdfd7 to fa063a6 Compare June 29, 2025 13:11

OskarStark changed the title ~~[W.I.P.] Fix implicit to and from bool type juggling~~ Fix implicit to and from bool type juggling Jun 29, 2025

OskarStark added the Status: Needs Work label Jun 29, 2025

Girgias mentioned this pull request Jul 11, 2025

Fix various bool-type coercions #61103

Merged

nicolas-grekas mentioned this pull request Jul 22, 2025

Remove some implicit bool type juggling #61203

Open

nicolas-grekas closed this Jul 22, 2025

Girgias deleted the bool-type-juggling branch July 27, 2025 20:01

Uh oh!

Fix implicit to and from bool type juggling #60890

Fix implicit to and from bool type juggling #60890

Conversation

Girgias commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carsonbot commented Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stof commented Jun 24, 2025

Uh oh!

Girgias commented Jun 24, 2025

Uh oh!

stof Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Girgias Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stof Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

Girgias Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

Girgias commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stof commented Jul 15, 2025

Uh oh!

nicolas-grekas commented Jul 22, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Girgias commented Jun 24, 2025 •

edited

Loading

Girgias commented Jun 29, 2025 •

edited

Loading