-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Mailer] Add MicrosoftGraph API Transport #61290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.4
Are you sure you want to change the base?
[Mailer] Add MicrosoftGraph API Transport #61290
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Don’t know if it’s related but it looks like you forgot to update symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php Line 2874 in 39c5025
|
a117a29
to
e5100cc
Compare
@MatTheCat You are today's hero, thank you! |
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/composer.json
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,41 @@ | |||
{ | |||
"name": "symfony/microsoft-graph-mailer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the factory is named .microsoftgraph
without underscore, this looks inconsistent, but I like the microsoft-graph
/microsoft_graph
more. cc @fabpot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is consistent with how AhaSend, MailerSend & MailPace are currently defined.
eb7c0ed
to
00ecd57
Compare
00ecd57
to
37f87a2
Compare
I believe the new test error is not related to the changes here... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I trust you've tested this against the real thing :)
Here are some nitpicking
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/TokenManager.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/TokenManager.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
Add a new Mailer bridge for the Microsoft Graph API, but without adding the complete Microsoft SDK as we're talking about just two HTTP POST requests.
I continued the work done in #60408 and kept the names mentioned there in the composer definition, but this implementation has been made from scratch, is based on the existing Azure Bridge and supports more features such as priority and inline attachments.