Skip to content

[Mailer] Add MicrosoftGraph API Transport #61290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: 7.4
Choose a base branch
from
Open

[Mailer] Add MicrosoftGraph API Transport #61290

wants to merge 15 commits into from
+1,029 −0

Conversation

bobvandevijver
Copy link
Contributor

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues Alternative for #60408
License MIT

Add a new Mailer bridge for the Microsoft Graph API, but without adding the complete Microsoft SDK as we're talking about just two HTTP POST requests.

I continued the work done in #60408 and kept the names mentioned there in the composer definition, but this implementation has been made from scratch, is based on the existing Azure Bridge and supports more features such as priority and inline attachments.

@carsonbot carsonbot added this to the 7.4 milestone Jul 31, 2025
@bobvandevijver bobvandevijver mentioned this pull request Jul 31, 2025
Closed
@bobvandevijver

This comment was marked as resolved.

Sign in to view
@MatTheCat
Copy link
Contributor

Don’t know if it’s related but it looks like you forgot to update registerMailerConfiguration’s $classToServices in the FrameworkExtension:

symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Line 2874 in 39c5025

$classToServices = [

@bobvandevijver bobvandevijver force-pushed the microsoft-graph-mailer branch from a117a29 to e5100cc Compare July 31, 2025 19:08
@bobvandevijver
Copy link
Contributor Author

@MatTheCat You are today's hero, thank you!

xabbuh
xabbuh reviewed Aug 1, 2025
View reviewed changes
@bobvandevijver bobvandevijver force-pushed the microsoft-graph-mailer branch 2 times, most recently from 00ecd57 to 37f87a2 Compare August 1, 2025 11:24
@bobvandevijver

This comment was marked as outdated.

Sign in to view
nicolas-grekas
nicolas-grekas approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I trust you've tested this against the real thing :)
Here are some nitpicking

@bobvandevijver bobvandevijver force-pushed the microsoft-graph-mailer branch from d69147f to e9e0276 Compare August 5, 2025 17:55
fabpot
fabpot requested changes Aug 6, 2025
View reviewed changes
bobvandevijver and others added 3 commits August 6, 2025 13:05
@bobvandevijver @fabpot
Apply suggestions from code review
b846301 
Co-authored-by: Fabien Potencier <fabien@potencier.org>
@bobvandevijver @fabpot
Update src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/M…
aee005d 
…icrosoftGraphTransportFactory.php

Co-authored-by: Fabien Potencier <fabien@potencier.org>
@bobvandevijver
Change other occurrences of microsoft+graphapi
0fc08d3
@bobvandevijver bobvandevijver requested a review from fabpot August 6, 2025 11:18
@bobvandevijver
Copy link
Contributor Author

Another test failure, but seems unrelated to the changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@OskarStark OskarStark OskarStark left review comments

@xabbuh xabbuh xabbuh left review comments

@fabpot fabpot Awaiting requested review from fabpot

Assignees
No one assigned
Labels
Feature Mailer Status: Needs Review
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
7 participants
@bobvandevijver @MatTheCat @fabpot @nicolas-grekas @OskarStark @xabbuh @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy