[Mailer] Add MicrosoftGraph API Transport #61290
Merged
+1,029
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Don’t know if it’s related but it looks like you forgot to update |
a117a29 to
e5100cc
Compare
|
@MatTheCat You are today's hero, thank you! |
xabbuh
reviewed
Aug 1, 2025
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/composer.json
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Aug 1, 2025
OskarStark
reviewed
Aug 1, 2025
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphApiTransport.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Aug 1, 2025
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Aug 1, 2025
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Aug 1, 2025
00ecd57 to
37f87a2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
nicolas-grekas
approved these changes
Aug 1, 2025
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/TokenManager.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/TokenManager.php
Outdated
Show resolved
Hide resolved
d69147f to
e9e0276
Compare
fabpot
requested changes
Aug 6, 2025
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
Outdated
Show resolved
Hide resolved
|
Another test failure, but seems unrelated to the changes here. |
fabpot
approved these changes
Aug 6, 2025
| } | ||
|
|
||
| if (null === $authEndpoint) { | ||
| throw new IncompleteDsnException("Transport 'microsoftgraph+api' requires the 'authEndpoint' option when not using the default graph endpoint."); |
There was a problem hiding this comment.
Suggested change
| throw new IncompleteDsnException("Transport 'microsoftgraph+api' requires the 'authEndpoint' option when not using the default graph endpoint."); | |
| throw new IncompleteDsnException('Transport "microsoftgraph+api" requires the "authEndpoint" option when not using the default graph endpoint.'); |
We are using " quotes in exception messages.
0fc08d3 to
7a1e3fb
Compare
|
Thank you @bobvandevijver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Mailer bridge for the Microsoft Graph API, but without adding the complete Microsoft SDK as we're talking about just two HTTP POST requests.
I continued the work done in #60408 and kept the names mentioned there in the composer definition, but this implementation has been made from scratch, is based on the existing Azure Bridge and supports more features such as priority and inline attachments.