Skip to content

replace PHPUnit annotations with attributes #61299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 7.4
Choose a base branch
from
Open

replace PHPUnit annotations with attributes #61299

wants to merge 1 commit into from
+4,421 −8,430

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 1, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 7.4 milestone Aug 1, 2025
@xabbuh
Copy link
Member Author

xabbuh commented Aug 1, 2025

this is a first step towards running our tests with PHPUnit 12.3, contains #58370 which needs to be merged first

@xabbuh xabbuh force-pushed the phpunit11-attributes branch from 482bc5d to 4d390cb Compare August 1, 2025 16:21
@nicolas-grekas
Copy link
Member

This has to be automated. Is that the case?
Otherwise, we're going to have a hard time when merging up, either immediately when merging into 8.0 or during the remaining 6.4 dev cycle

mttsch
mttsch reviewed Aug 1, 2025
View reviewed changes
src/Symfony/Bridge/PhpUnit/Tests/ClockMockTest.php
@@ -19,6 +20,7 @@
*
* @covers \Symfony\Bridge\PhpUnit\ClockMock
*/
#[CoversClass(ClockMock::class)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting here in the diff, the annotations sometimes remain and only the attributes are added, also see next case src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intended because we need to ensure that the PhpUnitBridge is working with PHPUnit 9.6 (we have a job for that) where the attributes don’t exist.

@xabbuh xabbuh force-pushed the phpunit11-attributes branch from 4d390cb to e8f65ff Compare August 1, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttsch mttsch mttsch left review comments

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@welcoMattic welcoMattic Awaiting requested review from welcoMattic welcoMattic is a code owner

@kbond kbond Awaiting requested review from kbond kbond is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @nicolas-grekas @mttsch @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy