replace PHPUnit annotations with attributes #61299
Merged
+4,500
−8,493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 1, 2025
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
|
this is a first step towards running our tests with PHPUnit 12.3, contains #58370 which needs to be merged first |
482bc5d to
4d390cb
Compare
|
This has to be automated. Is that the case? |
mttsch
reviewed
Aug 1, 2025
| @@ -19,6 +20,7 @@ | |||
| * | |||
| * @covers \Symfony\Bridge\PhpUnit\ClockMock | |||
| */ | |||
| #[CoversClass(ClockMock::class)] | |||
There was a problem hiding this comment.
Starting here in the diff, the annotations sometimes remain and only the attributes are added, also see next case src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php.
There was a problem hiding this comment.
This is intended because we need to ensure that the PhpUnitBridge is working with PHPUnit 9.6 (we have a job for that) where the attributes don’t exist.
4d390cb to
e8f65ff
Compare
HypeMC
reviewed
Aug 2, 2025
src/Symfony/Bridge/PhpUnit/Tests/Fixtures/coverage/tests/CoversTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/SecurityBundle/Tests/Functional/SecurityTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Functional/NotificationTest.php
Outdated
Show resolved
Hide resolved
3d02008 to
986a8bc
Compare
xabbuh
commented
Aug 3, 2025
753d83e to
721a920
Compare
721a920 to
982f89c
Compare
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.