replace PHPUnit annotations with attributes #61299
Conversation
xabbuh
commented
Aug 1, 2025
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
|
this is a first step towards running our tests with PHPUnit 12.3, contains #58370 which needs to be merged first |
482bc5d to
4d390cb
Compare
|
This has to be automated. Is that the case? |
| @@ -19,6 +20,7 @@ | |||
| * | |||
| * @covers \Symfony\Bridge\PhpUnit\ClockMock | |||
| */ | |||
| #[CoversClass(ClockMock::class)] | |||
There was a problem hiding this comment.
Starting here in the diff, the annotations sometimes remain and only the attributes are added, also see next case src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php.
There was a problem hiding this comment.
This is intended because we need to ensure that the PhpUnitBridge is working with PHPUnit 9.6 (we have a job for that) where the attributes don’t exist.
4d390cb to
e8f65ff
Compare
| /** | ||
| * @covers \DateTime | ||
| */ | ||
| #[\PHPUnit\Framework\Attributes\CoversClass(DateTime::class)] |
| * ["Symfony\\Bundle\\SecurityBundle\\Tests\\Functional\\Bundle\\AuthenticatorBundle\\ApiAuthenticator"] | ||
| */ | ||
| #[TestWith(['form_login'])] | ||
| #[TestWith(['Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\AuthenticatorBundle\ApiAuthenticator'])] |
There was a problem hiding this comment.
What about using ::class here:
| #[TestWith(['Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\AuthenticatorBundle\ApiAuthenticator'])] | |
| #[TestWith([ApiAuthenticator::class])] |
| /** | ||
| * @requires function \Symfony\Bundle\MercureBundle\MercureBundle::build | ||
| */ | ||
| #[RequiresFunction('Symfony\Bundle\MercureBundle\MercureBundle::build')] |
There was a problem hiding this comment.
Should RequiresMethod be used instead:
| #[RequiresFunction('Symfony\Bundle\MercureBundle\MercureBundle::build')] | |
| #[RequiresMethod(MercureBundle::class, 'build')] |