Update how to add custom Type #2725
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New in sf2.3, update the way we have to use to add custom Type.
| $childType = new TestChildType(); | ||
| return array(new PreloadedExtension(array( | ||
| $childType->getName() => $childType | ||
| ), array())); |
There was a problem hiding this comment.
this should be indented one level less
|
I made some comments, but except from those I'm +1. What you need to do to fix those comments is going to http://github.com/metfan/symfony-docs/tree/patch-1 then go to the file, edit it and commit it. |
|
👍 |
|
👍 This should fix #2485. |
|
ship it |
weaverryan
added a commit
that referenced
this pull request
Jun 30, 2013
Closed
|
thanks @weaverryan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2.3, we can't use anymore $this->factory->addType() t add custom Type to factory. We have to use PreloadedExtension class.